[PATCH v5 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC

Jammy Huang jammy_huang at aspeedtech.com
Fri Jun 27 12:22:37 AEST 2025


> On Wed, 2025-06-25 at 10:50 -0500, Rob Herring wrote:
> > On Wed, Jun 25, 2025 at 03:34:16PM +0800, Jammy Huang wrote:
> > > Introduce the mailbox module for AST27XX series SoC, which is
> > > responsible for interchanging messages between asymmetric processors.
> > >
> > > Signed-off-by: Jammy Huang <jammy_huang at aspeedtech.com>
> >
> 
> *snip*
> 
> > > +properties:
> > > +  compatible:
> > > +    const: aspeed,ast2700-mailbox
> > > +
> > > +  reg:
> > > +    maxItems: 2
> > > +    description:
> > > +      Contains the base addresses and sizes of the mailbox
> > > +controller. 1st one
> > > +      is for TX control register; 2nd one is for RX control register.
> >
> > Instead, just:
> >
> > items:
> >   - description: TX control register
> >   - description: RX control register
> 
> Maybe also specify reg-names with "tx" and "rx"? That way we can use
> devm_platform_ioremap_resource_byname() in the linux driver
> implementation, which should look tidier.
Sounds good. I will do it.
> 
> Andrew

Regards
Jammy


More information about the Linux-aspeed mailing list