回覆: [net-next v3 1/4] dt-bindings: net: ftgmac100: Add resets property
Jacky Chou
jacky_chou at aspeedtech.com
Wed Jul 9 15:52:12 AEST 2025
Hi Krzysztof
Thank you for your reply.
> > Add optional resets property for Aspeed SoCs to reset the MAC and
>
> s/Aspeed SoCs/Aspeed AST2600 SoCs/
>
> > RGMII/RMII.
>
> ... because ? It was missing? Incomplete? You changed hardware?
>
> Make the commits useful, explain WHY you are doing, not repeating WHAT
> you are doing. What is obvious from the diff. You already got this feedback with
> other patches.
>
Agreed.
Got it. I will add more commit message to describe why we do that and
what we do.
> >
> > Signed-off-by: Jacky Chou <jacky_chou at aspeedtech.com>
> > ---
> > .../bindings/net/faraday,ftgmac100.yaml | 23
> ++++++++++++++++---
> > 1 file changed, 20 insertions(+), 3 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > index 55d6a8379025..a2e7d439074a 100644
> > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > @@ -6,9 +6,6 @@ $schema:
> http://devicetree.org/meta-schemas/core.yaml#
> >
> > title: Faraday Technology FTGMAC100 gigabit ethernet controller
> >
> > -allOf:
> > - - $ref: ethernet-controller.yaml#
> > -
> > maintainers:
> > - Po-Yu Chuang <ratbert at faraday-tech.com>
> >
> > @@ -35,6 +32,11 @@ properties:
> > - description: MAC IP clock
> > - description: RMII RCLK gate for AST2500/2600
> >
> > + resets:
> > + maxItems: 1
> > + description:
> > + Optional reset control for the MAC controller
>
> Drop description, redundant and obvious form the schema. It cannot be a reset
> for anything else than MAC controller, because this is the MAC controller. It
> cannot be "non optional" because schema says it is optional.
>
> Write concise and USEFUL descriptions/commit messages, not just something
> to satisfy line/patch count.
Agreed.
I will adjust this part to meet schema.
Thanks,
Jacky
More information about the Linux-aspeed
mailing list