[PATCH] ARM: dts: aspeed: catalina: update catalina dts file

Andrew Jeffery andrew at codeconstruct.com.au
Wed Jan 8 11:47:36 AEDT 2025


Hi Potin,

On Fri, 2025-01-03 at 09:42 +0800, Potin Lai wrote:
> Update device nodes list below for driver binding.

The devicetree describes the hardware. I prefer we keep references to
drivers out of the commit message here.

> 
> - Add IOB NIC thermal nodes (TMP421)
>   - 24-001f, 26-001f, 36-001f, 38-001f
> - Add FIO Remote thermal node (TMP75)
>   - 23-001f
> - Add Power sensor node (MP5990)
>   - 16-0022
> - Add main source fan controllers (MAX31790)
>   - 18-0021, 18-0027
> - Add 2nd source fan controllers (NCT7363)
>   - 18-0001, 18-0002
> - Add 2nd source HSC nodes (XDP710)
>   - 20-0013, 20-001c
> - Remove all ina238 nodes, move to userspace
>   - 16-0041, 16-0042, 16-0044, 17-0041, 17-0043

This seems to reflect the patch itself, which isn't terribly helpful.
The commit message should explain _why_ you're making the changes.

Can you please rework it?

Andrew



More information about the Linux-aspeed mailing list