[PATCH v0 1/3] dt-binding: aspeed: Add LPC PCC controller

Kevin Chen kevin_chen at aspeedtech.com
Thu Feb 13 19:46:00 AEDT 2025


> On 17/01/2025 10:52, Kevin Chen wrote:
> > Add dt-bindings for Aspeed for Aspeed LPC POST code capture controller.
> >
> > Signed-off-by: Kevin Chen <kevin_chen at aspeedtech.com>
> > ---
> 
> Patchsets start from 1, not 0.
Agree, I will resend the patchsets of v1.

> 
> This wasn't tested as it has obvious errors, so no review. Test your patches
> before you send them.
Agree, I will run "make dtbs_check W=1" and " make dt_binding_check " to check result is clean before the next commits.

> 
> 
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
> to CC. It might happen, that command when run on an older kernel, gives you
> outdated entries. Therefore please be sure you base your patches on recent
> Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so
> fix your workflow. Tools might also fail if you work on some ancient tree (don't,
> instead use mainline) or work on fork of kernel (don't, instead use mainline).
> Just use b4 and everything should be fine, although remember about `b4 prep
> --auto-to-cc` if you added new patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be tested by
> automated tooling. Performing review on untested code might be a waste of
> time.
> 
> Please kindly resend and include all necessary To/Cc entries.
> </form letter>
> 
> Best regards,
> Krzysztof


More information about the Linux-aspeed mailing list