[PATCH v8 1/3] dt-binding: clock: ast2700: modify soc0/1 clock define
Krzysztof Kozlowski
krzk at kernel.org
Tue Feb 11 19:17:42 AEDT 2025
On Mon, Feb 10, 2025 at 04:50:02PM +0800, Ryan Chen wrote:
> remove soc0 clock:
Why? Your commit msg must explain why. What is obvious from the diff,
isn't it?
> SOC0_CLK_UART_DIV13
> SOC0_CLK_HPLL_DIV_AHB
> SOC0_CLK_MPLL_DIV_AHB
> add soc0 clock:
> SOC0_CLK_AHBMUX
> SOC0_CLK_MPHYSRC
> SOC0_CLK_U2PHY_REFCLKSRC
> add soc1 clock:
> SOC1_CLK_I3C
>
> Signed-off-by: Ryan Chen <ryan_chen at aspeedtech.com>
> ---
> include/dt-bindings/clock/aspeed,ast2700-scu.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/clock/aspeed,ast2700-scu.h b/include/dt-bindings/clock/aspeed,ast2700-scu.h
> index 63021af3caf5..c7389530629d 100644
> --- a/include/dt-bindings/clock/aspeed,ast2700-scu.h
> +++ b/include/dt-bindings/clock/aspeed,ast2700-scu.h
> @@ -13,18 +13,17 @@
> #define SCU0_CLK_24M 1
> #define SCU0_CLK_192M 2
> #define SCU0_CLK_UART 3
> -#define SCU0_CLK_UART_DIV13 3
NAK, ABI break without any explanation.
> #define SCU0_CLK_PSP 4
> #define SCU0_CLK_HPLL 5
> #define SCU0_CLK_HPLL_DIV2 6
> #define SCU0_CLK_HPLL_DIV4 7
> -#define SCU0_CLK_HPLL_DIV_AHB 8
> +#define SCU0_CLK_AHBMUX 8
NAK, ABI break without any explanation.
Best regards,
Krzysztof
More information about the Linux-aspeed
mailing list