[PATCH RFC 01/16] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema

Andrew Jeffery andrew at codeconstruct.com.au
Fri Dec 12 16:53:42 AEDT 2025


On Thu, 2025-12-11 at 12:27 -0800, Guenter Roeck wrote:
> On 12/11/25 00:45, Andrew Jeffery wrote:
> > From: "Rob Herring (Arm)" <robh at kernel.org>
> > 
> > Convert the ASpeed fan controller binding to DT schema format.
> > 
> > The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0
> > rather 1.
> > 
> > Some users define more that 8 fan nodes where 2 fans share a PWM. The
> > driver seems to let the 2nd fan just overwrite the 1st one. That also
> > creates some addressing errors in the DT (duplicate addresses and wrong
> > unit-addresses).
> > 
> > Signed-off-by: Rob Herring (Arm) <robh at kernel.org>
> > Signed-off-by: Andrew Jeffery <andrew at codeconstruct.com.au>
> 
> I am not sure I understand what the plan is here. I am assuming it will be
> applied through a non-hwmon branch.
> 
> Acked-by: Guenter Roeck <linux at roeck-us.net>

Thanks Guenter.

Apologies for confusion there. The series is currently a collection of
miscellaneous binding stuff that I felt needed DT maintainer input, so
I avoided adding driver subsystem maintainers in To/Cc to minimise
noise. Rob's feedback at [1] needs to be addressed - I'll make sure
you're in To: once that's sorted.

Andrew

[1]:
https://lore.kernel.org/all/20251211170333.GA1557987-robh@kernel.org/


More information about the Linux-aspeed mailing list