[net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100

[Jacky Chou]

Hi Andrew,

> > > > This patch series adds support for configuring RGMII internal
> > > > delays for the Aspeed AST2600 FTGMAC100 Ethernet MACs.
> > >
> > > So i think you are doing things in the wrong order. You first need
> > > to sort out the mess of most, if not all, AST2600 have the wrong
> > > phy-mode, because the RGMII delay configuration is hidden, and set
> wrongly.
> > >
> > > Please fix that first.
> > >
> >
> > The RGMII delay is configured in U-boot stage, and it is not changed
> > when booting to Linux. I want to know whether the first thing to
> > correct here is whether the phy-mode in aspeed-ast2600-evb.dts is
> > rgmii-id. Our AST2600 EVB, there is no delay on board, so, I need to change
> the phy-mode to "rgmii-id" to meet the RGMII usage first?
> 
> If there is no delay on the PCB, then phy-mode is "rgmii-id".

I would like to discuss with you how we fix the RGMII of AST2600 in this thread.
And thank you for your patience in reviewing our code.

Currently, the RGMII delay in AST2600 is configured in U-boot stage, not in Linux.
The ftgmac driver will not use the phy-mode to configure the RGMII delay on MAC side.

I list the parts that I think need to be modified.
1. Change the phy-mode to "rgmii-id" in aspeed-ast2600-evb.dts.
2. Add the tx/rx-internal-delay-ps in dts.
3. Add RGMII delay configuration in ftgmac driver. If the tx/rx-internal-delay-ps has not existed,
  according to the phy-mode to configure default value.

These are the fix items I can think of.
Could you point out what I miss or a clear direction to correct the RGMII mode on AST2600?

Thanks,
Jacky