回覆: [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100

[Jacky Chou]

Hi Andrew,

Thank you for your reply.

> > This patch series adds support for configuring RGMII internal delays
> > for the Aspeed AST2600 FTGMAC100 Ethernet MACs.
> 
> So i think you are doing things in the wrong order. You first need to sort out the
> mess of most, if not all, AST2600 have the wrong phy-mode, because the
> RGMII delay configuration is hidden, and set wrongly.
> 
> Please fix that first.
> 

The RGMII delay is configured in U-boot stage, and it is not changed when booting to
Linux. I want to know whether the first thing to correct here is whether the phy-mode
in aspeed-ast2600-evb.dts is rgmii-id. Our AST2600 EVB, there is no delay on board,
so, I need to change the phy-mode to "rgmii-id" to meet the RGMII usage first?

> Then consider how you can add fine tuning of the delays. Maybe that needs to
> wait for AST2700.

Currently, on AST2700, we use the "rgmii-id" in our SDK/git as per your suggestion.
And we will add the tx/rx-internal-delay-ps properties in the ftgmac100 driver to
support fine tuning of these delays.

Thanks,
Jacky