[PATCH 2/3] ARM: dts: aspeed: Add device tree includes for the cx8 switchboard
Krzysztof Kozlowski
krzk at kernel.org
Wed Aug 20 05:19:26 AEST 2025
On 19/08/2025 21:09, Marc Olberding wrote:
> On Sat, Aug 16, 2025 at 10:16:06AM +0200, Krzysztof Kozlowski wrote:
>>
>>
>>> +// SPDX-License-Identifier: GPL-2.0-or-later
>>
>> Odd license. Since when GPL-3.0 is okay?
>>
> Ack, missed this. Will fix.
>>> +
>>> +eeprom at 56 {
>>> + compatible = "atmel,24c128";
>>> + reg = <0x56>;
>>> +};
>>> +
>>
>> This is some completely misplaced DTSI style. Don't do this...
>
> Thanks for the feedback. I'm not sure which piece of this is wrong.
> Is the issue with having the contents of an i2c bus in a dtsi file?
> If so, would you prefer that we abandon the dtsi all together and
I think this should be just included in each bus needing it. It's really
odd to see a DTSI with top-level I2C devices.
Best regards,
Krzysztof
More information about the Linux-aspeed
mailing list