[PATCH v1 3/5] ARM: dts: aspeed: yosemite4: Change the address of Fan IC on fan boards

[Andrew Jeffery]

On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn at gmail.com>
> 
> Change the address of Fan IC: Max31790 on fan boards according to
> schematic.
> 
> Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn at gmail.com>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu at wiwynn.com>
> ---
>  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 24 +++++++------------
>  1 file changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index 430c28bdd314..a7e51725c595 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -496,10 +496,8 @@ adc at 1f {
>  			};
>  
>  			pwm at 20{
> -				compatible = "max31790";
> +				compatible = "maxim,max31790";

This isn't changing the address, it's fixing the compatible string.
Please make this a separate patch with an appropriate Fixes: tag.

>  				reg = <0x20>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;

Maybe put this in the same patch as the compatible fix though, if it's
correct.

>  			};
>  
>  			gpio at 22{
> @@ -509,11 +507,9 @@ gpio at 22{
>  				#gpio-cells = <2>;
>  			};
>  
> -			pwm at 23{
> -				compatible = "max31790";
> -				reg = <0x23>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> +			pwm at 2f{
> +				compatible = "maxim,max31790";
> +				reg = <0x2f>;
>  			};
>  
>  			adc at 33 {
> @@ -539,10 +535,8 @@ adc at 1f {
>  			};
>  
>  			pwm at 20{
> -				compatible = "max31790";
> +				compatible = "maxim,max31790";
>  				reg = <0x20>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;

As above for this diff hunk too.

Andrew

>  			};
>  
>  			gpio at 22{
> @@ -552,11 +546,9 @@ gpio at 22{
>  				#gpio-cells = <2>;
>  			};
>  
> -			pwm at 23{
> -				compatible = "max31790";
> -				reg = <0x23>;
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> +			pwm at 2f{
> +				compatible = "maxim,max31790";
> +				reg = <0x2f>;
>  			};
>  
>  			adc at 33 {