[PATCH v1 2/8] ARM: dts: aspeed: yosemite4: Add i2c-mux for four NICs
Andrew Jeffery
andrew at codeconstruct.com.au
Tue Oct 1 10:37:23 AEST 2024
On Mon, 2024-09-30 at 15:04 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn at gmail.com>
>
> Add i2c-mux on Spider board for four NICs and add the temperature sensor
> and EEPROM for the NICs.
>
> Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn at gmail.com>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu at wiwynn.com>
> ---
> .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 75 ++++++++++++++++++-
> 1 file changed, 72 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index dbc992a625b7..b813140b3c5b 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -26,6 +26,10 @@ aliases {
> i2c21 = &imux21;
> i2c22 = &imux22;
> i2c23 = &imux23;
> + i2c24 = &imux24;
> + i2c25 = &imux25;
> + i2c26 = &imux26;
> + i2c27 = &imux27;
> i2c34 = &imux34;
> i2c35 = &imux35;
> };
> @@ -1196,8 +1200,9 @@ adc at 35 {
> };
>
> &i2c15 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> status = "okay";
> - mctp-controller;
Why are you deleting this if you're not also deleting the MCTP endpoint
node?
Unless there's some reason this is related to the NICs, this should be
its own patch with its own justification.
Andrew
More information about the Linux-aspeed
mailing list