[PATCH] arm: dts: aspeed: Everest and Fuji: Add VRM presence gpio expander

Andrew Jeffery andrew at codeconstruct.com.au
Thu Nov 7 10:29:26 AEDT 2024


On Wed, 2024-11-06 at 13:33 -0600, Eddie James wrote:
> Add the gpio expander that provides the VRM presence detection
> pins.
> 
> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> ---
>  .../dts/aspeed/aspeed-bmc-ibm-everest.dts     | 27
> +++++++++++++++++++
>  .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts   | 27
> +++++++++++++++++++
>  2 files changed, 54 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> index 513077a1f4be..9961508ee872 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts
> @@ -353,6 +353,33 @@ pca1: pca9552 at 62 {
>                         "presence-base-op",
>                         "";
>         };
> +
> +       led-controller at 63 {
> +               compatible = "nxp,pca9552";

So Lee has queued the binding for the pca9552 in the leds tree[1], and
I've applied the patch on that basis.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git/commit/?h=for-leds-next&id=f92d2e9334171d07b47189397f222f64dcb77617

However, when merging for-leds-next into a tree with your patch here to
test, it surfaced a bunch of further (unrelated) issues:

    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 65: 'led at 10', 'led at 11' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 31: 'led at 10', 'led at 11', 'led at 12', 'led at 13', 'led at 14', 'led at 15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 32: 'led at 10', 'led at 11', 'led at 12', 'led at 13', 'led at 14', 'led at 15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 33: 'led at 10', 'led at 11', 'led at 12', 'led at 13', 'led at 14', 'led at 15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 30: 'led at 10', 'led at 11', 'led at 12', 'led at 13', 'led at 14', 'led at 15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 34: 'led at 10', 'led at 11', 'led at 12', 'led at 13', 'led at 14', 'led at 15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 35: 'led at 10', 'led at 11', 'led at 12', 'led at 13', 'led at 14', 'led at 15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
    +/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552 at 60: 'led at 10', 'led at 11', 'led at 12', 'led at 13' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
    +       from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#

Can you please send a follow-up patch resolving those and any similar
warnings for Fuji?

Thanks

Andrew


More information about the Linux-aspeed mailing list