[PATCH v1 2/5] usb: pxa27x_udc: Use devm_clk_get_enabled() helpers
Lei Liu
liulei.rjpt at vivo.com
Thu Aug 22 14:07:27 AEST 2024
The devm_clk_get_enabled() helpers:
- call devm_clk_get()
- call clk_prepare_enable() and register what is needed in order to
call clk_disable_unprepare() when needed, as a managed resource.
This simplifies the code and avoids calls to clk_disable_unprepare().
---
v0 -> v1
Incorrect usage of clk_prepare_enable() should be
corrected to devm_clk_get_enabled().
Signed-off-by: Lei Liu <liulei.rjpt at vivo.com>
---
drivers/usb/gadget/udc/pxa27x_udc.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
index 1a6317e4b2a3..6e99e75f1acb 100644
--- a/drivers/usb/gadget/udc/pxa27x_udc.c
+++ b/drivers/usb/gadget/udc/pxa27x_udc.c
@@ -2398,14 +2398,10 @@ static int pxa_udc_probe(struct platform_device *pdev)
if (udc->gpiod)
gpiod_direction_output(udc->gpiod, 0);
- udc->clk = devm_clk_get(&pdev->dev, NULL);
+ udc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(udc->clk))
return PTR_ERR(udc->clk);
- retval = clk_prepare(udc->clk);
- if (retval)
- return retval;
-
udc->vbus_sensed = 0;
the_controller = udc;
--
2.34.1
More information about the Linux-aspeed
mailing list