[PATCH v13 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2

[Ryan Chen]

> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for
> AST2600-i2cv2
> 
> On 20/08/2024 08:50, Ryan Chen wrote:
> >>>> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for
> >>>> AST2600-i2cv2
> >>>>
> >>>> On 19/08/2024 11:28, Ryan Chen wrote:
> >>>>> Add ast2600-i2cv2 compatible and aspeed,global-regs,
> >>>>> aspeed,enable-dma and description for ast2600-i2cv2.
> >>>>>
> >>>>> Signed-off-by: Ryan Chen <ryan_chen at aspeedtech.com>
> >>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt at kernel.org>
> >>>>
> >>>> ?!?
> >>>>
> >>>> What happened here? Why are you amending tags?!? That's not
> allowed.
> >>>> You cannot change received tags, change people names or their data!
> >>>> And how is it even possible, srsly, how do you even work with git?
> >>>> Git would never do it, so you had to do it on purpose via some
> >>>> weird
> >> workflow.
> >>>>
> >>> Sorry, I don't know Krzysztof Kozlowski
> >>> <krzysztof.kozlowski at linaro.org> is
> >> you or not.
> >>> Or should I still keep Krzysztof Kozlowski <krzk+dt at kernel.org>?
> >>>
> >>> https://patches.linaro.org/project/linux-i2c/patch/20230415012848.17
> >>> 77
> >>> 768-2-ryan_chen at aspeedtech.com/
> >>
> >> Here is the tag you received. You added it in v12.
> >>
> >> Why did you change the tag suddenly to something else?
> >>
> >> Do you understand that you are not allowed to change people tags? I
> >> have doubts if you ask about people's identities, which is entirely irrelevant.
> >>
> > Sorry, I am not understood.
> 
> I don't know how to say this simpler that you are not allowed to change tags.
> 
> You receive tag, use b4 to apply it or add it manually. Do not alter it.
> Do not change it. Do not add things there. Do not remove parts of it.
> 
> Tag is as is. You only copy and paste.
> 
> Is this understood now?
> 
> 
> 
> > https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777
> > 768-2-ryan_chen at aspeedtech.com/
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> at
> > v10 So, what should I do now at v13??
> 
> Fix your workflow and go back to previous version which had correct tag.
> And answer - why did you decide to change it?
> 
Sorry, I understand the tag means now.
It should keep original review-by tag. And send v14.

> Best regards,
> Krzysztof