回覆: [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC

[Kevin Chen]

Hi Krzk,

>> ---
>>  MAINTAINERS                  |  3 +++
>>  arch/arm64/Kconfig.platforms | 14 ++++++++++++++
>>  2 files changed, 17 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index c0a3d9e93689..08609430cfe0 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2121,7 +2121,10 @@ Q:     https://patchwork.ozlabs.org/project/linux-aspeed/list/
>>  T:   git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git
>>  F:   Documentation/devicetree/bindings/arm/aspeed/
>>  F:   arch/arm/boot/dts/aspeed/
>> +F:   arch/arm64/boot/dts/aspeed/
>>  F:   arch/arm/mach-aspeed/
>> +F:   include/dt-bindings/clock/aspeed,ast2700-clk.h
>> +F:   include/dt-bindings/reset/aspeed,ast2700-reset.h
>>  N:   aspeed
>>
>>  ARM/AXM LSI SOC
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 6c6d11536b42..1db7b6f1ee0a 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -40,6 +40,20 @@ config ARCH_APPLE
>>          This enables support for Apple's in-house ARM SoC family, starting
>>          with the Apple M1.
>>
>> +config ARCH_ASPEED
>> +     bool "Aspeed SoC family"
>> +     select MACH_ASPEED_G7
>> +     help
>> +       Say yes if you intend to run on an Aspeed ast2700 or similar
>> +       seventh generation Aspeed BMCs.
>> +
>> +config MACH_ASPEED_G7
>> +     bool "Aspeed SoC AST2700"
>
>There are no MACHines for arm64. Look at this code. Do you see MACH
>anywhere else? No. Then why Aspeed must be different?
>
>No. Drop.
Agree.

--
Best Regards,
Kevin. Chen

________________________________
寄件者: Krzysztof Kozlowski <krzk at kernel.org>
寄件日期: 2024年7月26日 下午 07:16
收件者: Kevin Chen <kevin_chen at aspeedtech.com>; robh at kernel.org <robh at kernel.org>; krzk+dt at kernel.org <krzk+dt at kernel.org>; conor+dt at kernel.org <conor+dt at kernel.org>; joel at jms.id.au <joel at jms.id.au>; andrew at codeconstruct.com.au <andrew at codeconstruct.com.au>; lee at kernel.org <lee at kernel.org>; catalin.marinas at arm.com <catalin.marinas at arm.com>; will at kernel.org <will at kernel.org>; arnd at arndb.de <arnd at arndb.de>; olof at lixom.net <olof at lixom.net>; soc at kernel.org <soc at kernel.org>; mturquette at baylibre.com <mturquette at baylibre.com>; sboyd at kernel.org <sboyd at kernel.org>; p.zabel at pengutronix.de <p.zabel at pengutronix.de>; quic_bjorande at quicinc.com <quic_bjorande at quicinc.com>; geert+renesas at glider.be <geert+renesas at glider.be>; dmitry.baryshkov at linaro.org <dmitry.baryshkov at linaro.org>; shawnguo at kernel.org <shawnguo at kernel.org>; neil.armstrong at linaro.org <neil.armstrong at linaro.org>; m.szyprowski at samsung.com <m.szyprowski at samsung.com>; nfraprado at collabora.com <nfraprado at collabora.com>; u-kumar1 at ti.com <u-kumar1 at ti.com>; devicetree at vger.kernel.org <devicetree at vger.kernel.org>; linux-arm-kernel at lists.infradead.org <linux-arm-kernel at lists.infradead.org>; linux-aspeed at lists.ozlabs.org <linux-aspeed at lists.ozlabs.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>; linux-clk at vger.kernel.org <linux-clk at vger.kernel.org>
主旨: Re: [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC

On 26/07/2024 13:03, Kevin Chen wrote:
> ---
>  MAINTAINERS                  |  3 +++
>  arch/arm64/Kconfig.platforms | 14 ++++++++++++++
>  2 files changed, 17 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c0a3d9e93689..08609430cfe0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2121,7 +2121,10 @@ Q:     https://patchwork.ozlabs.org/project/linux-aspeed/list/
>  T:   git git://git.kernel.org/pub/scm/linux/kernel/git/joel/bmc.git
>  F:   Documentation/devicetree/bindings/arm/aspeed/
>  F:   arch/arm/boot/dts/aspeed/
> +F:   arch/arm64/boot/dts/aspeed/
>  F:   arch/arm/mach-aspeed/
> +F:   include/dt-bindings/clock/aspeed,ast2700-clk.h
> +F:   include/dt-bindings/reset/aspeed,ast2700-reset.h
>  N:   aspeed
>
>  ARM/AXM LSI SOC
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 6c6d11536b42..1db7b6f1ee0a 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -40,6 +40,20 @@ config ARCH_APPLE
>          This enables support for Apple's in-house ARM SoC family, starting
>          with the Apple M1.
>
> +config ARCH_ASPEED
> +     bool "Aspeed SoC family"
> +     select MACH_ASPEED_G7
> +     help
> +       Say yes if you intend to run on an Aspeed ast2700 or similar
> +       seventh generation Aspeed BMCs.
> +
> +config MACH_ASPEED_G7
> +     bool "Aspeed SoC AST2700"

There are no MACHines for arm64. Look at this code. Do you see MACH
anywhere else? No. Then why Aspeed must be different?

No. Drop.

Best regards,
Krzysztof

************* Email Confidentiality Notice ********************
免責聲明:
本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!

DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/23685db3/attachment-0001.htm>