回覆: [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB device tree
Kevin Chen
kevin_chen at aspeedtech.com
Thu Aug 15 15:50:41 AEST 2024
Hi Krzk,
>> ---
>> arch/arm64/boot/dts/aspeed/Makefile | 4 ++
>> arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 ++++++++++++++++++++++
>> 2 files changed, 54 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/aspeed/Makefile
>> create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
>>
>> diff --git a/arch/arm64/boot/dts/aspeed/Makefile b/arch/arm64/boot/dts/aspeed/Makefile
>> new file mode 100644
>> index 000000000000..ffe7e15017cc
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/aspeed/Makefile
>> @@ -0,0 +1,4 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +
>> +dtb-$(CONFIG_ARCH_ASPEED) += \
>> + ast2700-evb.dtb
>> diff --git a/arch/arm64/boot/dts/aspeed/ast2700-evb.dts b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
>> new file mode 100644
>> index 000000000000..187c458e566b
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
>> @@ -0,0 +1,50 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +
>> +/dts-v1/;
>> +
>> +#include "aspeed-g7.dtsi"
>> +#include <dt-bindings/gpio/aspeed-gpio.h>
>> +
>> +/ {
>> + model = "AST2700A1-EVB";
>> + compatible = "aspeed,ast2700a1-evb", "aspeed,ast2700";
>
>You have never tested this.
>
>Sorry, test your DTS first.
Agree. I will test my dts by make dtbs_check W=1
>
>> +
>> + chosen {
>> + bootargs = "console=ttyS12,115200n8";
>
>Drop.
Agree.
>
>> + stdout-path = &uart12;
>> + };
>> +
>> + firmware {
>> + optee: optee {
>> + compatible = "linaro,optee-tz";
>> + method = "smc";
>> + };
>> + };
>> +
>> + memory at 400000000 {
>> + device_type = "memory";
>> + reg = <0x4 0x00000000 0x0 0x40000000>;
>> + };
>> +
>> + reserved-memory {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
>> +
>> + mcu_fw: mcu-firmware at 42fe00000 {
>> + reg = <0x4 0x2fe00000 0x0 0x200000>;
>> + no-map;
>> + };
>> +
>> + atf: trusted-firmware-a at 430000000 {
>> + reg = <0x4 0x30000000 0x0 0x80000>;
>> + no-map;
>> + };
>> +
>> + optee_core: optee_core at 430080000 {
>
>Read DTS coding style.
Agree. Should I change to optee_core: optee-core at 430080000 {
>
>> + reg = <0x4 0x30080000 0x0 0x1000000>;
>> + no-map;
>> + };
>> + };
>> +};
>> +
>
>Remove stray blank line.
Agree.
--
Best Regards,
Kevin. Chen
________________________________
寄件者: Krzysztof Kozlowski <krzk at kernel.org>
寄件日期: 2024年7月26日 下午 07:16
收件者: Kevin Chen <kevin_chen at aspeedtech.com>; robh at kernel.org <robh at kernel.org>; krzk+dt at kernel.org <krzk+dt at kernel.org>; conor+dt at kernel.org <conor+dt at kernel.org>; joel at jms.id.au <joel at jms.id.au>; andrew at codeconstruct.com.au <andrew at codeconstruct.com.au>; lee at kernel.org <lee at kernel.org>; catalin.marinas at arm.com <catalin.marinas at arm.com>; will at kernel.org <will at kernel.org>; arnd at arndb.de <arnd at arndb.de>; olof at lixom.net <olof at lixom.net>; soc at kernel.org <soc at kernel.org>; mturquette at baylibre.com <mturquette at baylibre.com>; sboyd at kernel.org <sboyd at kernel.org>; p.zabel at pengutronix.de <p.zabel at pengutronix.de>; quic_bjorande at quicinc.com <quic_bjorande at quicinc.com>; geert+renesas at glider.be <geert+renesas at glider.be>; dmitry.baryshkov at linaro.org <dmitry.baryshkov at linaro.org>; shawnguo at kernel.org <shawnguo at kernel.org>; neil.armstrong at linaro.org <neil.armstrong at linaro.org>; m.szyprowski at samsung.com <m.szyprowski at samsung.com>; nfraprado at collabora.com <nfraprado at collabora.com>; u-kumar1 at ti.com <u-kumar1 at ti.com>; devicetree at vger.kernel.org <devicetree at vger.kernel.org>; linux-arm-kernel at lists.infradead.org <linux-arm-kernel at lists.infradead.org>; linux-aspeed at lists.ozlabs.org <linux-aspeed at lists.ozlabs.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>; linux-clk at vger.kernel.org <linux-clk at vger.kernel.org>
主旨: Re: [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB device tree
On 26/07/2024 13:03, Kevin Chen wrote:
> ---
> arch/arm64/boot/dts/aspeed/Makefile | 4 ++
> arch/arm64/boot/dts/aspeed/ast2700-evb.dts | 50 ++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 arch/arm64/boot/dts/aspeed/Makefile
> create mode 100644 arch/arm64/boot/dts/aspeed/ast2700-evb.dts
>
> diff --git a/arch/arm64/boot/dts/aspeed/Makefile b/arch/arm64/boot/dts/aspeed/Makefile
> new file mode 100644
> index 000000000000..ffe7e15017cc
> --- /dev/null
> +++ b/arch/arm64/boot/dts/aspeed/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +dtb-$(CONFIG_ARCH_ASPEED) += \
> + ast2700-evb.dtb
> diff --git a/arch/arm64/boot/dts/aspeed/ast2700-evb.dts b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> new file mode 100644
> index 000000000000..187c458e566b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/aspeed/ast2700-evb.dts
> @@ -0,0 +1,50 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +
> +/dts-v1/;
> +
> +#include "aspeed-g7.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> + model = "AST2700A1-EVB";
> + compatible = "aspeed,ast2700a1-evb", "aspeed,ast2700";
You have never tested this.
Sorry, test your DTS first.
> +
> + chosen {
> + bootargs = "console=ttyS12,115200n8";
Drop.
> + stdout-path = &uart12;
> + };
> +
> + firmware {
> + optee: optee {
> + compatible = "linaro,optee-tz";
> + method = "smc";
> + };
> + };
> +
> + memory at 400000000 {
> + device_type = "memory";
> + reg = <0x4 0x00000000 0x0 0x40000000>;
> + };
> +
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + mcu_fw: mcu-firmware at 42fe00000 {
> + reg = <0x4 0x2fe00000 0x0 0x200000>;
> + no-map;
> + };
> +
> + atf: trusted-firmware-a at 430000000 {
> + reg = <0x4 0x30000000 0x0 0x80000>;
> + no-map;
> + };
> +
> + optee_core: optee_core at 430080000 {
Read DTS coding style.
> + reg = <0x4 0x30080000 0x0 0x1000000>;
> + no-map;
> + };
> + };
> +};
> +
Remove stray blank line.
Best regards,
Krzysztof
************* Email Confidentiality Notice ********************
免責聲明:
本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!
DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/be8746ea/attachment-0001.htm>
More information about the Linux-aspeed
mailing list