回覆: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU

[Kevin Chen]

Hi Krzk,

I will speperate clock part in the v3 patch into Ryan's clock series.

>Missing commit msg.
>
>Please use subject prefixes matching the subsystem. You can get them for
>example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
>your patch is touching. For bindings, the preferred subjects are
>explained here:
>https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
>A nit, subject: drop second/last, redundant "bindings for". The
>"dt-bindings" prefix is already stating that these are bindings.
>See also:
>https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Agree, already fixed in another commit in Ryan's series.
[1/4] dt-bindings: mfd: aspeed: support for AST2700 - Patchwork (kernel.org)<https://patchwork.kernel.org/project/linux-clk/patch/20240808075937.2756733-2-ryan_chen@aspeedtech.com/>

--
Best Regards,
Kevin. Chen

________________________________
寄件者: Krzysztof Kozlowski <krzk at kernel.org>
寄件日期: 2024年7月26日 下午 07:10
收件者: Kevin Chen <kevin_chen at aspeedtech.com>; robh at kernel.org <robh at kernel.org>; krzk+dt at kernel.org <krzk+dt at kernel.org>; conor+dt at kernel.org <conor+dt at kernel.org>; joel at jms.id.au <joel at jms.id.au>; andrew at codeconstruct.com.au <andrew at codeconstruct.com.au>; lee at kernel.org <lee at kernel.org>; catalin.marinas at arm.com <catalin.marinas at arm.com>; will at kernel.org <will at kernel.org>; arnd at arndb.de <arnd at arndb.de>; olof at lixom.net <olof at lixom.net>; soc at kernel.org <soc at kernel.org>; mturquette at baylibre.com <mturquette at baylibre.com>; sboyd at kernel.org <sboyd at kernel.org>; p.zabel at pengutronix.de <p.zabel at pengutronix.de>; quic_bjorande at quicinc.com <quic_bjorande at quicinc.com>; geert+renesas at glider.be <geert+renesas at glider.be>; dmitry.baryshkov at linaro.org <dmitry.baryshkov at linaro.org>; shawnguo at kernel.org <shawnguo at kernel.org>; neil.armstrong at linaro.org <neil.armstrong at linaro.org>; m.szyprowski at samsung.com <m.szyprowski at samsung.com>; nfraprado at collabora.com <nfraprado at collabora.com>; u-kumar1 at ti.com <u-kumar1 at ti.com>; devicetree at vger.kernel.org <devicetree at vger.kernel.org>; linux-arm-kernel at lists.infradead.org <linux-arm-kernel at lists.infradead.org>; linux-aspeed at lists.ozlabs.org <linux-aspeed at lists.ozlabs.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>; linux-clk at vger.kernel.org <linux-clk at vger.kernel.org>
主旨: Re: [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU

On 26/07/2024 13:03, Kevin Chen wrote:
> Signed-off-by: Kevin Chen <kevin_chen at aspeedtech.com>

Missing commit msg.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

A nit, subject: drop second/last, redundant "bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18



Best regards,
Krzysztof

************* Email Confidentiality Notice ********************
免責聲明:
本信件(或其附件)可能包含機密資訊，並受法律保護。如 台端非指定之收件者，請以電子郵件通知本電子郵件之發送者, 並請立即刪除本電子郵件及其附件和銷毀所有複印件。謝謝您的合作!

DISCLAIMER:
This message (and any attachments) may contain legally privileged and/or other confidential information. If you have received it in error, please notify the sender by reply e-mail and immediately delete the e-mail and any attachments without copying or disclosing the contents. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20240815/b56b5015/attachment-0001.htm>