[PATCH 2/4] dt-bindings: reset Add AST2700 reset bindings

Krzysztof Kozlowski krzk at kernel.org
Fri Aug 9 16:07:23 AEST 2024


On 09/08/2024 07:42, Ryan Chen wrote:
>>> +#define SCU0_RESET_PORTA_EHCI              (38)
>>> +#define SCU0_RESET_PORTA_VHUB0             (38)
>>
>> Is having 38 twice expected?
>> If not, why not use an enum, BTW?
>>
> Yes, it is expected. Due to 38 is shared reset for 2 usb controller.
> One for EHCI, another is for vhub0. So I do define the same value.
> That I can do more clear in dtsi description.
> The following will be expected dtsi file descript.

No, that's confusing. Don't do this. You are hiding information that one
reset is shared. Terrible idea.

Best regards,
Krzysztof



More information about the Linux-aspeed mailing list