[PATCH v3 2/4] dt-bindings: rtc: convert trivial devices into dtschema

Javier Carrasco javier.carrasco.cruz at gmail.com
Mon Apr 15 16:35:12 AEST 2024


On 4/15/24 02:09, Andrew Jeffery wrote:
> On Sat, 2024-04-13 at 22:22 +0200, Javier Carrasco wrote:
>> These RTCs meet the requirements for a direct conversion into
>> trivial-rtc:
>>
>> - google,goldfish-rtc
>> - maxim,ds1742
>> - lpc32xx-rtc
>> - orion-rtc
>> - rtc-aspeed
>> - spear-rtc
>> - via,vt8500-rtc
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> Reviewed-by: Andrew Jeffery <andrew at codeconstruct.com.au>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz at gmail.com>
> 
> We have trailers above but then there's more commit message content
> below. Looks like what's below should be trimmed out (bad squash)?
> Maybe the trimming could be done as its applied?
> 
>>
>> dt-bindings: rtc: lpc32xx-rtc: convert to dtschema
>>
>> Convert existing binding to dtschema to support validation.
>>
>> Add the undocumented 'clocks' property.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz at gmail.com>
> 
> Andrew


You are right, the commit message content below your comment should not
be there. I can send a new version to trim it away if that is preferred.

Best regards,
Javier Carrasc


More information about the Linux-aspeed mailing list