[PATCH v4 17/17] fsi: scom: Update compatible string to match documentation
Krzysztof Kozlowski
krzk at kernel.org
Tue Apr 30 17:37:30 AEST 2024
On 29/04/2024 23:01, Eddie James wrote:
> Use p9-scom instead of fsi2pib.
Why? Commits must *always* say why you are doing it. What is easy to see.
>
> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> ---
> drivers/fsi/fsi-scom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index 61dbda9dbe2b..18ca213fdc7e 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -589,7 +589,7 @@ static int scom_remove(struct device *dev)
> }
>
> static const struct of_device_id scom_of_ids[] = {
> - { .compatible = "ibm,fsi2pib" },
> + { .compatible = "ibm,p9-scom" },
This breaks all users without any explanation in the commit!
Best regards,
Krzysztof
More information about the Linux-aspeed
mailing list