[PATCH 03/52] serial: 8250: Convert to platform remove callback returning void

Andi Shyti andi.shyti at linux.intel.com
Thu Nov 23 10:23:28 AEDT 2023

Hi Uwe,

On Fri, Nov 10, 2023 at 04:29:31PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>


More information about the Linux-aspeed mailing list