[PATCH 03/52] serial: 8250: Convert to platform remove callback returning void

Florian Fainelli florian.fainelli at broadcom.com
Sat Nov 11 04:49:32 AEDT 2023

On 11/10/23 07:29, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---

Reviewed-by: Florian Fainelli <florian.fainelli at broadcom.com> # 8250_bcm*

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4221 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20231110/c09b53f7/attachment-0001.p7s>

More information about the Linux-aspeed mailing list