[PATCH] aspeed-video.c: Fix error checking for debugfs_create_dir

Osama Muhammad osmtendev at gmail.com
Thu May 25 03:11:37 AEST 2023


This patch fixes the error checking in aspeed-video.c in
debugfs_create_dir. The correct way to check if an error occurred
is using 'IS_ERR' inline function.

Signed-off-by: Osama Muhammad <osmtendev at gmail.com>
---
 drivers/media/platform/aspeed/aspeed-video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/aspeed/aspeed-video.c b/drivers/media/platform/aspeed/aspeed-video.c
index 374eb7781936..97847f44964a 100644
--- a/drivers/media/platform/aspeed/aspeed-video.c
+++ b/drivers/media/platform/aspeed/aspeed-video.c
@@ -1976,7 +1976,7 @@ static int aspeed_video_debugfs_create(struct aspeed_video *video)
 	debugfs_entry = debugfs_create_file(DEVICE_NAME, 0444, NULL,
 					    video,
 					    &aspeed_video_debugfs_fops);
-	if (!debugfs_entry)
+	if (IS_ERR(debugfs_entry))
 		aspeed_video_debugfs_remove(video);
 
 	return !debugfs_entry ? -EIO : 0;
-- 
2.34.1



More information about the Linux-aspeed mailing list