[PATCH 2/2] dtsi:aspeed: add miss pinctrl in pinctrl dtsi

Ryan Chen ryan_chen at aspeedtech.com
Mon Jan 30 19:31:19 AEDT 2023


Hello Andrew,
	Thanks your review. I will separate the patch to submit.

Ryan Chen

> -----Original Message-----
> From: Andrew Jeffery <andrew at aj.id.au>
> Sent: Monday, January 23, 2023 9:33 AM
> To: Ryan Chen <ryan_chen at aspeedtech.com>; openbmc at lists.ozlabs.org; Rob
> Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt at linaro.org>; Joel Stanley <joel at jms.id.au>; Linus
> Walleij <linus.walleij at linaro.org>; linux-aspeed at lists.ozlabs.org
> Subject: Re: [PATCH 2/2] dtsi:aspeed: add miss pinctrl in pinctrl dtsi
> 
> Hi Ryan,
> 
> On Tue, 3 Jan 2023, at 20:07, ryan_chen wrote:
> > add miss pcie rc, secure i2c, i3c, 8bit emmc, uart ncts..
> 
> Please make sure that any new functions and groups are documented in the
> devicetree bindings. Also, updates to the binding documentation should be in
> their own patch, separate to the changes to the devicetree itself.
> 
> Cheers,
> 
> Andrew


More information about the Linux-aspeed mailing list