[PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver

[Neal Liu]

> -----Original Message-----
> From: Herbert Xu <herbert at gondor.apana.org.au>
> Sent: Friday, December 30, 2022 4:29 PM
> To: Neal Liu <neal_liu at aspeedtech.com>
> Cc: Rob Herring <robh+dt at kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt at linaro.org>; Joel Stanley <joel at jms.id.au>; Andrew
> Jeffery <andrew at aj.id.au>; David S . Miller <davem at davemloft.net>;
> ChiaWei Wang <chiawei_wang at aspeedtech.com>;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org;
> linux-crypto at vger.kernel.org; Christoph Hellwig <hch at infradead.org>
> Subject: Re: [PATCH v4 1/4] crypto: aspeed: Add ACRY RSA driver
> 
> On Wed, Dec 14, 2022 at 03:01:11PM +0800, Neal Liu wrote:
> >
> > +static u8 *aspeed_rsa_key_copy(u8 *src, size_t len) {
> > +	return kmemdup(src, len, GFP_DMA | GFP_KERNEL);
> 
> Please explain why you are using GFP_DMA.

Looks like it's unnecessary. I'll remove it.
Thanks.

> Thanks,
> --
> Email: Herbert Xu <herbert at gondor.apana.org.au> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt