[PATCH v2 2/3] clk: aspeed: Add full configs for i3c clocks

Jeremy Kerr jk at codeconstruct.com.au
Mon Feb 13 23:34:14 AEDT 2023


Hi Krzysztof,

> Bindings are always separate patches.

OK, I'll split these up into the dt-bindings and the clk changes.

> > diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> > index d8b0db2f7a7d..600549d7bee8 100644
> > --- a/include/dt-bindings/clock/ast2600-clock.h
> > +++ b/include/dt-bindings/clock/ast2600-clock.h
> > @@ -57,8 +57,6 @@
> >  #define ASPEED_CLK_GATE_I3C3CLK                40
> >  #define ASPEED_CLK_GATE_I3C4CLK                41
> >  #define ASPEED_CLK_GATE_I3C5CLK                42
> > -#define ASPEED_CLK_GATE_I3C6CLK                43
> > -#define ASPEED_CLK_GATE_I3C7CLK                44
> 
> This is an ABI break and commit msg does not really justify it.

I'll add more rationale there.

Cheers,


Jeremy



More information about the Linux-aspeed mailing list