[RFC PATCH] dt-bindings: Add AST2600 i3c controller binding
Jeremy Kerr
jk at codeconstruct.com.au
Mon Feb 13 19:55:38 AEDT 2023
Hi Krzysztof,
> 1. Do not use "This commit/patch".
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
OK.
> 2. Use subject prefixes matching the subsystem (which you can get for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory your patch is touching).
So "dt-bindings: i3c:" instead of just "d-bindings:" here.
> 3. Subject: drop second/last, redundant "binding". The "dt-bindings"
> prefix is already stating that these are bindings.
OK.
> 4. Where is the driver? Where is the DTS? Why do we want unused
> binding in the kernel?
The driver is coming next, but I wanted to sort out the structure of the
binding before committing to how the driver consumes the DT data - hence
the RFC.
Cheers,
Jeremy
More information about the Linux-aspeed
mailing list