[PATCH] usb: gadget: aspeed: fix buffer overflow
yulei.sh at bytedance.com
Fri Oct 28 18:41:53 AEDT 2022
On Fri, Oct 28, 2022 at 2:59 PM Neal Liu <neal_liu at aspeedtech.com> wrote:
> Thanks for your feedback.
> I tried to reproduce it on my side, and it cannot be reproduce it.
> Here are my test sequences:
> 1. emulate one of the vhub port to usb ethernet through Linux gadget (ncm)
We are using rndis instead of ncm.
> 2. connect BMC vhub to Host
> 3. BMC & Host can ping each other (both usb eth dev default mtu is 1500)
> 4. Set BMC mtu to 1000 (Host OS cannot set usb eth dev mtu to 2000, it's maxmtu is 1500)
Not sure if it's related, but in my case (USB rndis, Debian 10 OS) it
should be able to set MTU to 2000.
> 5. ping BMC with `s -1500` argument from Host OS
> 6. BMC kernel no oops
> I dumped the `req` related members in ast_vhub_epn_handle_ack() to see if whether the received data length exceeds the buffer length.
> In my case `req.length` is 16384 bytes, so it never exceeds it in this case.
> I'm wondering what's the value of `req.length` in your test scenario? And how can I reproduce it?
The last 3 calls of ast_vhub_epn_handle_ack():
We can see the last packet 1634 exceeds the req.legnth 1578, and
that's when the buffer overflow occurs.
More information about the Linux-aspeed