[PATCH v2 36/36] pinctrl: Clean up headers

Andy Shevchenko andriy.shevchenko at linux.intel.com
Tue Oct 11 20:07:05 AEDT 2022


On Tue, Oct 11, 2022 at 10:46:30AM +0200, Geert Uytterhoeven wrote:
> On Tue, Oct 11, 2022 at 9:31 AM Basavaraj Natikar <bnatikar at amd.com> wrote:
> > On 10/11/2022 1:44 AM, Andy Shevchenko wrote:

> > > +++ b/drivers/pinctrl/core.h

> > > -#include <linux/pinctrl/pinconf.h>
> >
> > Removing pinconf.h from the core.h may cause build failure in other files
> > because where-ever core.h is included to use “struct pinconf_ops”, there
> > is a need to include pinconf.h.
> 
> I can confirm adding
> 
>     #include <linux/pinctrl/pinconf.h>
> 
> to drivers/pinctrl/renesas/pinctrl-rzn1.c and drivers/pinctrl/pinctrl-single.c
> fixes the issues I was seeing with shmobile_defconfig and (out-of-tree)
> renesas_defconfig.

I will add this, thank you for reporting.

-- 
With Best Regards,
Andy Shevchenko




More information about the Linux-aspeed mailing list