[PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc

Neal Liu neal_liu at aspeedtech.com
Mon May 16 16:00:28 AEST 2022


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Sent: Monday, May 16, 2022 1:54 PM
> To: Neal Liu <neal_liu at aspeedtech.com>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>; Rob Herring <robh+dt at kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt at linaro.org>; Joel Stanley <joel at jms.id.au>;
> Andrew Jeffery <andrew at aj.id.au>; Felipe Balbi <balbi at kernel.org>; Sumit
> Semwal <sumit.semwal at linaro.org>; Christian König
> <christian.koenig at amd.com>; Geert Uytterhoeven <geert at linux-m68k.org>;
> Li Yang <leoyang.li at nxp.com>
> Cc: linux-aspeed at lists.ozlabs.org; linux-usb at vger.kernel.org;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org; linux-media at vger.kernel.org;
> dri-devel at lists.freedesktop.org; linaro-mm-sig at lists.linaro.org
> Subject: Re: [PATCH 3/3] dt-bindings: usb: add documentation for aspeed udc
> 
> On 16/05/2022 03:59, Neal Liu wrote:
> >>> Okay, I could rename it for next patch if you preferred.
> >>> But there are lots of yaml files which are not named as first compatible.
> >>
> >> Yes, I know, I quite likely I also produced such bindings, but a
> >> specific name is rather preferred. Otherwise you will have a
> >> difficult naming choice when your next Aspeed UDC requires new
> >> bindings file because of some differences (not yet known now).
> >>
> > We can rename the bindings if next Aspeed UDC needs, don't you think?
> > Currently, Aspeed has no requirement.
> 
> So just use proper name from the beginning....
>
Okay, I'll rename it for next patch.
Thanks for the review.

> 
> Best regards,
> Krzysztof


More information about the Linux-aspeed mailing list