[PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

Dylan Hung dylan_hung at aspeedtech.com
Tue Mar 22 13:32:13 AEDT 2022


> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk at kernel.org]
> Sent: 2022年3月21日 11:53 PM
> To: Dylan Hung <dylan_hung at aspeedtech.com>; robh+dt at kernel.org;
> joel at jms.id.au; andrew at aj.id.au; andrew at lunn.ch; hkallweit1 at gmail.com;
> linux at armlinux.org.uk; davem at davemloft.net; kuba at kernel.org;
> pabeni at redhat.com; p.zabel at pengutronix.de; devicetree at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org;
> linux-kernel at vger.kernel.org; netdev at vger.kernel.org
> Cc: BMC-SW <BMC-SW at aspeedtech.com>; stable at vger.kernel.org
> Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO
> nodes
> 
> On 21/03/2022 10:56, Dylan Hung wrote:
> > Add reset control properties into MDIO nodes.  The 4 MDIO controllers in
> > AST2600 SOC share one reset control bit SCU50[3].
> >
> > Signed-off-by: Dylan Hung <dylan_hung at aspeedtech.com>
> > Cc: stable at vger.kernel.org
> 
> Please describe the bug being fixed. See stable-kernel-rules.

Thank you for your comment.
The reset deassertion of the MDIO device was usually done by the bootloader (u-boot).
However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO
reset so failed to access the HW in kernel driver.  The reset deassertion is missing in the
kernel driver since it was created, should I add a BugFix for the first commit of this driver?
Or would it be better if I remove " Cc: stable at vger.kernel.org"?

> 
> Best regards,
> Krzysztof


More information about the Linux-aspeed mailing list