[SPAM] [PATCH 1/1] mtd: spi-nor: aspeed: set the decoding size to at least 2MB for AST2600
Cédric Le Goater
clg at kaod.org
Tue Mar 8 17:26:24 AEDT 2022
> Thanks for taking this patch into spi-mem driver, the tested log as below.
> [ 1.945705] spi-nor spi1.0: mx25l8005 (1024 Kbytes)
> [ 1.945926] spi-aspeed-smc 1e630000.spi: CE0 window resized to 2MB (AST2600 Decoding)
> aspeed_smc_flash_set_segment CS0 segreg=0x100000 [ 0x30000000 - 0x30200000 ]
> aspeed_smc_flash_set_segment CS1 segreg=0x7f00020 [ 0x30200000 - 0x38000000 ]
> [ 1.953083] spi-aspeed-smc 1e630000.spi: Calibration area too uniform, using low speed
> [ 1.953409] spi-aspeed-smc 1e630000.spi: CE0 read buswidth:1 [0x000b0041]
Thanks for the test !
> By the way, there is a small error when compiling kernel, it needs forward declare for both ast2600_spi_data & ast2600_fmc_data.
Ah yes ! Sorry, I pushed a wrong version. I just did an update on my tree.
May be we should introduce some helpers to identify the SoC.
> Also, I saw you add ast2600_fmc_data for resize checking as well, should I add it in aspeed-smc.c and resend the patch?
Both AST2600 controllers have the same encoding of the flash window
range, so, yes the old driver needs it.
More information about the Linux-aspeed