[PATCH v6 5/9] regmap: Introduces regmap lock helpers

Quan Nguyen quan at os.amperecomputing.com
Mon Mar 7 19:31:13 AEDT 2022


On 24/12/2021 20:19, Mark Brown wrote:
> On Fri, Dec 24, 2021 at 11:13:48AM +0700, Quan Nguyen wrote:
>> This commit introduces regmap_acquire/release_lock() functions and makes
>> them available for drivers that need atomic access of regmap registers
> 
> You've not explained what something would need this for and how
> it's expected to work - we don't provide unlocked access to the
> regmap to client drivers so I don't see how one could safely use
> this.  It's unclear to me what this would mean or why it's not
> better implemented in the client driver.

Thanks a lot for the review, Mark.
As per my comment in the other email, this code will be removed in my 
next version.

Thanks,
- Quan


More information about the Linux-aspeed mailing list