[PATCH 2/6] treewide: remove using list iterator after loop body as a ptr
torvalds at linux-foundation.org
Wed Mar 2 06:42:26 AEDT 2022
On Tue, Mar 1, 2022 at 11:06 AM Linus Torvalds
<torvalds at linux-foundation.org> wrote:
> So instead of that simple "if (!entry)", we'd effectively have to
> continue to use something that still works with the old world order
> (ie that "if (list_entry_is_head())" model).
Just to prove my point about how this is painful, that doesn't work at all.
If the loop iterator at the end is NULL (good, in theory), we can't
use "list_entry_is_head()" to check whether we ended. We'd have to use
a new thing entirely, to handle the "list_for_each_entry() has the
old/new semantics" cases.
That's largely why I was pushing for the "let's make it impossible to
use the loop iterator at all outside the loop". It avoids the
confusing case, and the patches to move to that stricter semantic can
be merged independently (and before) doing the actual semantic change.
I'm not saying my suggested approach is wonderful either. Honestly,
it's painful that we have so nasty semantics for the end-of-loop case
The minimal patch would clearly be to keep those broken semantics, and
just force everybody to use the list_entry_is_head() case. That's the
"we know we messed up, we are too lazy to fix it, we'll just work
around it and people need to be careful" approach.
And laziness is a virtue. But bad semantics are bad semantics. So it's
a question of balancing those two issues.
More information about the Linux-aspeed