[PATCH v2] usb: gadget: aspeed_udc: fix handling of tx_len == 0

Greg Kroah-Hartman gregkh at linuxfoundation.org
Fri Jun 24 21:35:54 AEST 2022


On Fri, Jun 24, 2022 at 02:01:18AM +0000, Neal Liu wrote:
> > The bug is that we should still enter this loop if "tx_len" is zero.
> > 
> > Reported-by: Neal Liu <neal_liu at aspeedtech.com>
> > Fixes: c09b1f372e74 ("usb: gadget: aspeed_udc: cleanup loop in
> > ast_dma_descriptor_setup()")
> > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> > ---
> > v2: Remove the unnecessary "chunk >= 0" condition
> 
> I mean v1 looks good to me.
> Sorry if you are misunderstanding.

I have no idea if v1 or v2 is the "correct" one here, sorry.

Dan, can you send a v3 that you all agree on?

thanks,

greg k-h


More information about the Linux-aspeed mailing list