[PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0

Neal Liu neal_liu at aspeedtech.com
Fri Jun 24 17:46:50 AEST 2022

> (switching back to my normal "community" email)
> On Fri, 2022-06-24 at 09:34 +0300, Dan Carpenter wrote:
> > > Hrm... what is that driver ? I've missed it ... is the code lifted
> > > from aspeed-vhub ? If yes, should we instead make it a common code
> > > base ?
> > > And if there are bug fixes on one they might apply to the other as
> > > well...
> >
> >
> > No, I'm the person who introduced the bug so it's unique to this
> > driver.
> Ok thanks. That said, the code looks fairly similar to the vhub code, so my
> comment stands, if this is the same IP block, which it appears to be, the driver
> should be common.
> IE. The vhub is made of a virtual hub with a bunch of UDCs underneath, this
> appears to address the ast2600 "new" standalone (no hub) variant of said UDC
> if I'm not mistaken.
> The way I structured the code in vhub, it shouldn't be overly difficult to make it
> standalone. I wrote (and maintain) aspeed-vhub and would be happy to work
> on this if I got sent an ast2600 board.

Hi Ben, This UDC is the independent IP. The ast2600 board can run aspeed-vhub & aspeed_udc simultaneously with different USB port.
I think it's no need to restruct the code in vhub.

More information about the Linux-aspeed mailing list