[PATCH] fsi: Aspeed: Fix a potential double free

Dan Carpenter dan.carpenter at oracle.com
Thu Jan 6 19:14:19 AEDT 2022

On Mon, Dec 27, 2021 at 07:29:07AM +0100, Greg KH wrote:
> On Sun, Dec 26, 2021 at 05:56:02PM +0100, Christophe JAILLET wrote:
> > 'aspeed' is a devm_alloc'ed, so there is no need to free it explicitly or
> > there will be a double free().
> A struct device can never be devm_alloced for obvious reasons.  Perhaps
> that is the real problem here?

I don't understand how "aspeed" is a struct device.

I've been working on understanding device managed memory recently for
Smatch.  It's really complicated.  There are a bunch of rules/heuristics
that I'm slowly creating to generate new warnings but I'm a long way
from understanding it well myself.

dan carpenter

More information about the Linux-aspeed mailing list