[PATCH] crypto: aspeed: fix return value check in aspeed_hace_probe()
Sun Ke
sunke32 at huawei.com
Tue Aug 30 13:13:47 AEST 2022
In case of error, the function devm_ioremap_resource() returns
ERR_PTR() not NULL. The NULL test in the return value check must be
replaced with IS_ERR().
Fixes: 108713a713c7 ("crypto: aspeed - Add HACE hash driver")
Signed-off-by: Sun Ke <sunke32 at huawei.com>
---
drivers/crypto/aspeed/aspeed-hace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/aspeed/aspeed-hace.c b/drivers/crypto/aspeed/aspeed-hace.c
index 4fefc9e69d72..3f880aafb6a2 100644
--- a/drivers/crypto/aspeed/aspeed-hace.c
+++ b/drivers/crypto/aspeed/aspeed-hace.c
@@ -123,9 +123,9 @@ static int aspeed_hace_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, hace_dev);
hace_dev->regs = devm_ioremap_resource(&pdev->dev, res);
- if (!hace_dev->regs) {
+ if (IS_ERR(hace_dev->regs)) {
dev_err(&pdev->dev, "Failed to map resources\n");
- return -ENOMEM;
+ return PTR_ERR(hace_dev->regs);
}
/* Get irq number and register it */
--
2.31.1
More information about the Linux-aspeed
mailing list