[PATCH] irqchip: Replace update_bits with write_bits.
joel at jms.id.au
Wed Nov 24 20:50:01 AEDT 2021
On Wed, 24 Nov 2021 at 09:43, Billy Tsai <billy_tsai at aspeedtech.com> wrote:
> The interrupt status bits are cleared by writing 1, we should force a
> write to clear the interrupt without checking if the value has changed.
> Fixes: 04f605906ff0 ("irqchip: Add Aspeed SCU interrupt controller")
> Signed-off-by: Billy Tsai <billy_tsai at aspeedtech.com>
Good catch. This should go to stable too.
Reviewed-by: Joel Stanley <joel at jms.id.au>
Is there any reason to use the regmap abstraction in this driver?
AFAICT the registers aren't shared, so we could replace the regmap
calls with readl/writel. Such a cleanup probably wouldn't be
backported, so this patch is still useful.
> drivers/irqchip/irq-aspeed-scu-ic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/irqchip/irq-aspeed-scu-ic.c b/drivers/irqchip/irq-aspeed-scu-ic.c
> index f3c6855a4cef..18b77c3e6db4 100644
> --- a/drivers/irqchip/irq-aspeed-scu-ic.c
> +++ b/drivers/irqchip/irq-aspeed-scu-ic.c
> @@ -76,8 +76,8 @@ static void aspeed_scu_ic_irq_handler(struct irq_desc *desc)
> bit - scu_ic->irq_shift);
> - regmap_update_bits(scu_ic->scu, scu_ic->reg, mask,
> - BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT));
> + regmap_write_bits(scu_ic->scu, scu_ic->reg, mask,
> + BIT(bit + ASPEED_SCU_IC_STATUS_SHIFT));
> chained_irq_exit(chip, desc);
More information about the Linux-aspeed