[PATCH] drm/aspeed: Fix vga_pw sysfs output

Joel Stanley joel at jms.id.au
Fri Nov 19 18:07:39 AEDT 2021

Hi David, Daniel,

On Fri, 19 Nov 2021 at 06:54, Jeremy Kerr <jk at codeconstruct.com.au> wrote:
> Hi Joel,
> > Before the drm driver had support for this file there was a driver
> > that exposed the contents of the vga password register to userspace.
> > It would present the entire register instead of interpreting it.
> >
> > The drm implementation chose to mask of the lower bit, without
> > explaining why. This breaks the existing userspace, which is looking
> > for 0xa8 in the lower byte.
> >
> > Change our implementation to expose the entire register.
> As a userspace consumer of this:
> Reviewed-by: Jeremy Kerr <jk at codeconstruct.com.au>

Am I okay to apply this to drm-misc-fixes? I've not applied a patch to
the fixes tree before, so I wanted to check if there is some process
I've missed.



More information about the Linux-aspeed mailing list