[RFC PATCH 6/6] pinctrl: Check get_group_pins callback on init
Andrew Jeffery
andrew at aj.id.au
Fri Jul 23 17:58:58 AEST 2021
Do configurations exist where this doesn't make sense? I lost some time
to debugging the fact that I was missing the callback :(
Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
---
drivers/pinctrl/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index e4862552eb9b..4c436a419856 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1994,7 +1994,8 @@ static int pinctrl_check_ops(struct pinctrl_dev *pctldev)
if (!ops ||
!ops->get_groups_count ||
- !ops->get_group_name)
+ !ops->get_group_name ||
+ !ops->get_group_pins)
return -EINVAL;
return 0;
--
2.30.2
More information about the Linux-aspeed
mailing list