[PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

Neal Liu neal_liu at aspeedtech.com
Wed Dec 1 13:09:43 AEDT 2021


> -----Original Message-----
> From: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Sent: Tuesday, November 30, 2021 7:43 PM
> To: Neal Liu <neal_liu at aspeedtech.com>
> Cc: Felipe Balbi <balbi at kernel.org>; Joel Stanley <joel at jms.id.au>; Andrew
> Jeffery <andrew at aj.id.au>; Cai Huoqing <caihuoqing at baidu.com>; Tao Ren
> <rentao.bupt at gmail.com>; Julia Lawall <julia.lawall at inria.fr>; kernel test
> robot <lkp at intel.com>; Sasha Levin <sashal at kernel.org>;
> linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org;
> benh at kernel.crashing.org; BMC-SW <BMC-SW at aspeedtech.com>
> Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor
> 
> On Tue, Nov 30, 2021 at 07:38:44PM +0800, Neal Liu wrote:
> > +Ben.
> > ---
> >
> > Support qualifier descriptor to pass USB30CV compliance test.
> >
> > Signed-off-by: Neal Liu <neal_liu at aspeedtech.com>
> > ---
> 
> The way you wrote this means that everything below the first --- line will be cut
> off if it were to be applied.
> 
> That is not what you want.
> 
> Please fix.
> 
> thanks,
> 
> greg k-h

Yes, I'll fix it. Thanks

-Neal


More information about the Linux-aspeed mailing list