[PATCH 00/22] ARM: dts: aspeed: Updates for Rainier and Everest machines

Joel Stanley joel at jms.id.au
Thu Apr 8 11:31:01 AEST 2021

On Mon, 29 Mar 2021 at 15:00, Eddie James <eajames at linux.ibm.com> wrote:
> This series updates the device trees for the Rainier and Everest system
> BMCs. For Rainier, the changes have been tested fairly extensively in
> hardware. Everest has largely been tested in simulation and some basic
> hardware verification testing.

>   ARM: dts: aspeed: rainier: Support pass 2 planar

This patch does not build, suggesting it has not been tested. I fixed
it by adding the extra fan nodes that rainier was missing.

How about we support only the latest planar in the mainline tree, and
support for older versions can be carried in the downstream tree?

>   ARM: dts: Aspeed: Everest: Add max31785 fan controller device

This has been applied, but without the properties that are not upstream.

>   ARM: dts: aspeed: rainier: Add Operator Panel LEDs
>   ARM: dts: aspeed: rainier: Add leds that are off PCA9552
>   ARM: dts: aspeed: rainier: Add leds that are off pic16f882
>   ARM: dts: aspeed: rainier: Add leds on optional DASD cards
>   ARM: dts: aspeed: rainier: Add leds on optional PCI cable cards

These need to be re-worked to use the PCA driver directly instead of
exposing PCA LED devices as GPIO controllers and then attaching
gpio-leds to those GPIOs.

Country to previous concerns raised, there was no issue with "holes"
in the layout but instead a desire to avoid the "pca955x:" prefix in
sysfs. For now userspace will ignore that prefix when matching
devices. I also have a proposed patch to remove them:


The changes I have merged have been pushed here. Please double check
that I've merged what you expected:




More information about the Linux-aspeed mailing list