[PATCH v2 1/2] gpio/aspeed-sgpio: enable access to all 80 input & output sgpios

Bartosz Golaszewski bgolaszewski at baylibre.com
Thu Sep 24 23:11:28 AEST 2020


On Wed, Sep 16, 2020 at 2:59 PM Joel Stanley <joel at jms.id.au> wrote:
>
> On Wed, 16 Sep 2020 at 11:09, Bartosz Golaszewski
> <bgolaszewski at baylibre.com> wrote:
> >
> > On Wed, Sep 16, 2020 at 6:51 AM Joel Stanley <joel at jms.id.au> wrote:
> > >
> > > Hi GPIO maintainers,
> > >
> > > On Fri, 11 Sep 2020 at 02:20, Joel Stanley <joel at jms.id.au> wrote:
> > > >
> > > > On Fri, 11 Sep 2020 at 02:11, Jeremy Kerr <jk at codeconstruct.com.au> wrote:
> > > > >
> > > > > Currently, the aspeed-sgpio driver exposes up to 80 GPIO lines,
> > > > > corresponding to the 80 status bits available in hardware. Each of these
> > > > > lines can be configured as either an input or an output.
> > > > >
> > > > > However, each of these GPIOs is actually an input *and* an output; we
> > > > > actually have 80 inputs plus 80 outputs.
> > > > >
> > > > > This change expands the maximum number of GPIOs to 160; the lower half
> > > > > of this range are the input-only GPIOs, the upper half are the outputs.
> > > > > We fix the GPIO directions to correspond to this mapping.
> > > > >
> > > > > This also fixes a bug when setting GPIOs - we were reading from the
> > > > > input register, making it impossible to set more than one output GPIO.
> > > > >
> > > > > Signed-off-by: Jeremy Kerr <jk at codeconstruct.com.au>
> > > > > Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> > > >
> > > > Reviewed-by: Joel Stanley <joel at jms.id.au>
> > >
> > > This series is good to go in for 5.10:
> > >
> >
> > Hi Joel,
> >
> > I don't have this in my inbox. Did you copy me on this series?
>
> I did not; I am not the author of the patches as you can see.
>
> I notice that Jeremy sent them to the linux-gpio list, but you were
> not copied. Are you able to grab them from lore, or do you need him to
> resend them?
>
> Cheers,
>
> Joel

Now queued, thanks.

Bartosz


More information about the Linux-aspeed mailing list