Re: [PATCH v2 2/2] gpio/aspeed-sgpio: don't enable all interrupts by default

Andrew Jeffery andrew at aj.id.au
Fri Sep 11 13:29:21 AEST 2020



On Fri, 11 Sep 2020, at 11:21, Jeremy Kerr wrote:
> Currently, the IRQ setup for the SGPIO driver enables all interrupts in
> dual-edge trigger mode. Since the default handler is handle_bad_irq, any
> state change on input GPIOs will trigger bad IRQ warnings.
> 
> This change applies sensible IRQ defaults: single-edge trigger, and all
> IRQs disabled.
> 
> Signed-off-by: Jeremy Kerr <jk at codeconstruct.com.au>
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")

Acked-by: Andrew Jeffery <andrew at aj.id.au>


More information about the Linux-aspeed mailing list