[PATCH 2/2] gpio/aspeed-sgpio: don't enable all interrupts by default

Jeremy Kerr jk at codeconstruct.com.au
Fri Sep 11 11:12:11 AEST 2020

Hi Joel,

> And also removing the enabling of IRQs. This part makes sense, as
> it's what the commit message says.
> If you think a sensible default should be single edge (and I would
> agree with that change), perhaps update the comment to say "set
> single edge trigger mode" and mention it in your commit message.

OK, shall do. That was my intention with the "reasonable defaults"
reference, but being explicit about that better here.

I'll send a v2 with an updated commit message.



More information about the Linux-aspeed mailing list