[PATCH v1 7/7] fsi: aspeed: add unspecified HAS_IOMEM dependency
brendanhiggins at google.com
Mon Jan 27 20:46:25 AEDT 2020
On Wed, Dec 11, 2019 at 4:30 PM Brendan Higgins
<brendanhiggins at google.com> wrote:
> On Wed, Dec 11, 2019 at 4:12 PM Joel Stanley <joel at jms.id.au> wrote:
> > On Wed, 11 Dec 2019 at 19:28, Brendan Higgins <brendanhiggins at google.com> wrote:
> > >
> > > Currently CONFIG_FSI_MASTER_ASPEED=y implicitly depends on
> > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
> > > the following build error:
> > >
> > > ld: drivers/fsi/fsi-master-aspeed.o: in function `fsi_master_aspeed_probe':
> > > drivers/fsi/fsi-master-aspeed.c:436: undefined reference to `devm_ioremap_resource'
> > >
> > > Fix the build error by adding the unspecified dependency.
> > >
> > > Reported-by: Brendan Higgins <brendanhiggins at google.com>
> > > Signed-off-by: Brendan Higgins <brendanhiggins at google.com>
> > Nice. I hit this when attempting to force on CONFIG_COMPILE_TEST in
> > order to build some ARM drivers under UM. Do you have plans to fix
> > that too?
> The only broken configs I found for UML are all listed on the cover
> letter of this patch. I think fixing COMPILE_TEST on UM could be
> worthwhile. Did you see any brokenness other than what I mentioned on
> the cover letter?
> > Do you want to get this in a fix for 5.5?
> Preferably, yes.
> > Acked-by: Joel Stanley <joel at jms.id.au>
Hey, I know I owe you a reply about debugging your kunitconfig (I'll
try to get to that this week); nevertheless, it looks like this patch
didn't make it into 5.5. Can you make sure it gets into 5.6? It
shouldn't depend on anything else.
More information about the Linux-aspeed