[External] Re: [PATCH 1/3] misc: aspeed: Add Aspeed UART routing control driver.
yulei.sh at bytedance.com
Fri Dec 11 13:06:05 AEDT 2020
On Thu, Dec 10, 2020 at 8:33 PM Oskar Senft <osk at google.com> wrote:
> The purpose of this driver is to allow manipulation of the UART routing at runtime. Setting the routing in the DTS would obviously not allow that.
> From what I remember, I used am existing unrelated driver as template. Apologies for using the wrong APIs - I literally just followed what I had seen elsewhere.
> Since posting this driver, we found that while it solved our initial use case, that use case has evolved. We're now using Aspeed's VUART where bytes are routed "manually" (i.e. copied between devices) rather than in hardware. So I don't need this driver anymore.
> If it's still useful to anyone, please take ownership and modify it as needed to be able to submit it. I'm still happy to keep an eye on it and help explain its purpose.
The driver is useful for our system, and it's used in intel-openbmc as well.
We (John and I work for the same employer) have the chance to use
Andrew Jefery's ["bmc-misc" driver] to configure the various
registers in dts to setup the UART routing, but that driver was not
accepted by upstream.
So we end up sending this patch here for upstream's comment.
If it's considered not a good option, we will have to keep it downstream.
More information about the Linux-aspeed