[PATCH v2 1/2] misc: Add clock control logic into Aspeed LPC SNOOP driver

Arnd Bergmann arnd at kernel.org
Wed Dec 9 17:41:41 AEDT 2020


On Wed, Dec 9, 2020 at 3:17 AM Joel Stanley <joel at jms.id.au> wrote:
>
> On Tue, 8 Dec 2020 at 09:17, John Wang <wangzhiqiang.bj at bytedance.com> wrote:
> >
> > From: Jae Hyun Yoo <jae.hyun.yoo at intel.com>
> >
> > If LPC SNOOP driver is registered ahead of lpc-ctrl module, LPC
> > SNOOP block will be enabled without heart beating of LCLK until
> > lpc-ctrl enables the LCLK. This issue causes improper handling on
> > host interrupts when the host sends interrupt in that time frame.
> > Then kernel eventually forcibly disables the interrupt with
> > dumping stack and printing a 'nobody cared this irq' message out.
> >
> > To prevent this issue, all LPC sub-nodes should enable LCLK
> > individually so this patch adds clock control logic into the LPC
> > SNOOP driver.
> >
> > Fixes: 3772e5da4454 ("drivers/misc: Aspeed LPC snoop output using misc
> > chardev")
> >
> > Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at intel.com>
> > Signed-off-by: Vernon Mauery <vernon.mauery at linux.intel.com>
> > Signed-off-by: John Wang <wangzhiqiang.bj at bytedance.com>
>
> Reviewed-by: Joel Stanley <joel at jms.id.au>
>
> Arnd, can you merge this for v5.11, or would you prefer me to do a pull request?
>
> The device tree patch from this series also needs to be added.

Sure, please forward the patches to soc at kernel.org so I can
grab them from patchwork.

      Arnd


More information about the Linux-aspeed mailing list