[PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

Stefan Schaeckeler (sschaeck) sschaeck at cisco.com
Mon Dec 7 19:57:00 AEDT 2020

Hello Troy,

> Hi Stefan,
> The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off 
> from u-boot and check if driver runs correctly.

I noticed now most changes are these "exports". As you removed them a later revision, the patch looks now lean and clean. I'll give you my Reviewed-by tag after you addressed Andrew's last comment.

> The test doc you provided is very nice and detailed, I'll try to reproduce the 
> injection test in v2 patch.

It does not harm to redo the testing. That is time-consuming and with your current, now trivial changes, it's not really necessary.


More information about the Linux-aspeed mailing list